security: upgrade rxjs from v6.x to 7.8.0#15
Closed
egg-sourcegraph-testing[bot] wants to merge 1 commit into
Closed
security: upgrade rxjs from v6.x to 7.8.0#15egg-sourcegraph-testing[bot] wants to merge 1 commit into
egg-sourcegraph-testing[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Sourcegraph Egg <egg@sourcegraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
rxjsfrom any v6.x.x release to 7.8.0 and migrates allbreaking API changes required for compatibility with rxjs v7.
Changes made
package.json: bumpedrxjsto7.8.0rxjs/operatorsimports →rxjsroot importsthrowError(value)→throwError(() => value)(v7 factory signature).toPromise()→lastValueFrom()with appropriate importrxjs-compatif presentrxjs/internal/*imports with TODO comments for manual reviewWhy
rxjs v6 is end-of-life. v7 ships with significantly improved TypeScript typings,
smaller bundle sizes, and better tree-shaking. All v6.x versions should be
considered unmaintained.
Testing
Please verify the build and tests pass before merging. Pay special attention to
any
rxjs/internal/*TODO comments added by this PR.Hatched by a Sourcegraph egg.