Skip to content

Upgrade TypeScript and modernize practices #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sqs wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade TypeScript and modernize practices #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"parcel-bundler": "^1.11.0",
"sourcegraph": "^23.0.0",
"tslint": "^5.15.0",
"typescript": "^3.4.2"
"typescript": "^3.7.4"
},
"dependencies": {
"localforage": "^1.7.3",
Expand Down
4 changes: 2 additions & 2 deletions src/cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export class CachedMap<K extends string, V> {
/**
* @param id The unique ID of this map to distinguish it from other items in the cache.
*/
constructor(private id: string) {}
constructor(private readonly id: string) {}

private getFullKey(key: K): string {
return `${this.id}__${key}`
Expand Down Expand Up @@ -52,7 +52,7 @@ export class CachedAsyncValue<V> {
/**
* @param id The unique ID of this value to distinguish it from other items in the cache.
*/
constructor(private id: string, private compute: () => Promise<V>) {}
constructor(private readonly id: string, private readonly compute: () => Promise<V>) {}

private async computeAndStore(): Promise<void> {
this.promise = this.compute()
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4993,10 +4993,10 @@ typedarray@^0.0.6:
resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=

typescript@^3.4.2:
version "3.4.2"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.4.2.tgz#9ed4e6475d906f589200193be056f5913caed481"
integrity sha512-Og2Vn6Mk7JAuWA1hQdDQN/Ekm/SchX80VzLhjKN9ETYrIepBFAd8PkOdOTK2nKt0FCkmMZKBJvQ1dV1gIxPu/A==
typescript@^3.7.4:
version "3.7.4"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.7.4.tgz#1743a5ec5fef6a1fa9f3e4708e33c81c73876c19"
integrity sha512-A25xv5XCtarLwXpcDNZzCGvW2D1S3/bACratYBx2sax8PefsFhlYmkQicKHvpYflFS8if4zne5zT5kpJ7pzuvw==

unicode-canonical-property-names-ecmascript@^1.0.4:
version "1.0.4"
Expand Down