Closed
Conversation
TheRedDaemon
requested changes
Apr 13, 2026
| @@ -1,5 +1,7 @@ | |||
| #pragma once | |||
|
|
|||
| typedef int WINBOOL; | |||
Contributor
There was a problem hiding this comment.
OK, I am curious:
This one is not part of the Windows.h header?
From where is it and where do we need it?
Contributor
Author
There was a problem hiding this comment.
Exported Direct x 8 stuff needs it (function signatures). It should be in Windows psapi.h but I couldn't find it. Therefore this stub.
I remember now, WINBOOL is in psapi.h in windows 10 SDK but not in the msvc1400 SDK. WINBOOL doesn't exist in MSVC1400 for some reason while it should. I also can't trace it using the dplay.h headers I found online.
Funnily enough, our dplay.h from 2007 just uses BOOL... I guess this is a non-issue and should be fixed in Ghidra instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing WINBOOL type in a predictable location