Skip to content

fix: add WINBOOL type #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gynt wants to merge 1 commit into from
Closed

fix: add WINBOOL type #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/precomp/common.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#pragma once

typedef int WINBOOL;
Copy link
Copy Markdown
Contributor

@TheRedDaemon TheRedDaemon Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I am curious:
This one is not part of the Windows.h header?
From where is it and where do we need it?

Copy link
Copy Markdown
Contributor Author

@gynt gynt Apr 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exported Direct x 8 stuff needs it (function signatures). It should be in Windows psapi.h but I couldn't find it. Therefore this stub.
I remember now, WINBOOL is in psapi.h in windows 10 SDK but not in the msvc1400 SDK. WINBOOL doesn't exist in MSVC1400 for some reason while it should. I also can't trace it using the dplay.h headers I found online.
Funnily enough, our dplay.h from 2007 just uses BOOL... I guess this is a non-issue and should be fixed in Ghidra instead.


namespace Ghidra {
typedef void* pointer;
typedef void* pointer32;
Expand Down
Loading