Skip to content

ROX-33133: Re-enable post-quantum crypto-policies for Collector#3448

Open
vladbologa wants to merge 1 commit into
masterfrom
vb/re-enable-pqc
Open

ROX-33133: Re-enable post-quantum crypto-policies for Collector#3448
vladbologa wants to merge 1 commit into
masterfrom
vb/re-enable-pqc

Conversation

@vladbologa

@vladbologa vladbologa commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

#2977 enabled post-quantum crypto policies in the Collector image.

Unfortunately #3021 removed that change. This PR re-enables the PQC policies.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

@vladbologa vladbologa requested review from a team and rhacs-bot as code owners June 11, 2026 09:50
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 01a7c19f-3c3a-44c8-8ff9-5a006fac7ab9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vb/re-enable-pqc

Comment @coderabbitai help to get the list of available commands and usage tips.

@rhacs-bot rhacs-bot requested a review from a team June 11, 2026 09:50
@vladbologa vladbologa requested a review from janisz June 11, 2026 09:53
@codecov-commenter

codecov-commenter commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.34%. Comparing base (339edbf) to head (bf1e4af).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3448   +/-   ##
=======================================
  Coverage   27.34%   27.34%           
=======================================
  Files          95       95           
  Lines        5420     5420           
  Branches     2545     2545           
=======================================
  Hits         1482     1482           
  Misses       3211     3211           
  Partials      727      727           
Flag Coverage Δ
collector-unit-tests 27.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Molter73 Molter73 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this line was removed during the review of the mentioned PR, sorry about that! LGTM!

@github-actions

Copy link
Copy Markdown

/retest collector-on-push

@github-actions

Copy link
Copy Markdown

/retest collector-on-push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants