NoDynamicNameRule: Skip named lookup on known object#264
Merged
Conversation
staabm
commented
May 21, 2026
| { | ||
| // trick to allow multiple node types | ||
| return Node::class; | ||
| return Expr::class; |
Contributor
Author
There was a problem hiding this comment.
use a more specific parent type, so the rule is called less often
staabm
commented
May 21, 2026
| public function run() | ||
| { | ||
| $object = $this->getObject(); | ||
| if ($object::MY_CONSTANT === 3) { |
Contributor
Author
There was a problem hiding this comment.
the main motivation of this PR:
I think its fine to do a named lookup on a variable, as long as its a union of known types
staabm
commented
May 21, 2026
| { | ||
| /** | ||
| * @param array<int, array<string|int>> $expectedErrorMessagesWithLines | ||
| * @param list<array{string, int, 2?: string|null}> $expectedErrorMessagesWithLines |
Contributor
Author
There was a problem hiding this comment.
drive-by phpstan error cleanup
Contributor
Author
|
the failling rector build is unrelated (affects files not touch in this PR) |
Member
|
Thanks for the feature 👍 Still, passing CI is still a requirement. |
Contributor
Author
|
ok cool. I let rector process the unrelated files. thank you! |
Member
|
Very nice, the improvement makes sense 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix false positive