NoDynamicNameRule: Skip named lookup on known object

src/Rules/Doctrine/NoRepositoryCallInDataFixtureRule.php

@@ -48,7 +48,7 @@ public function processNode(Node $node, Scope $scope): array
         }
 
         $methodName = $node->name->toString();
-        if (! in_array($methodName, ['getRepository', 'find', 'findAll', 'findBy', 'findOneBy'])) {
+        if (! in_array($methodName, ['getRepository', 'find', 'findAll', 'findBy', 'findOneBy'], true)) {
             return [];
         }
 

src/Rules/Explicit/ExplicitClassPrefixSuffixRule.php

@@ -14,8 +14,8 @@
 use PHPStan\Rules\IdentifierRuleError;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
-use function str_ends_with;
 use Symplify\PHPStanRules\Enum\RuleIdentifier;
+use function str_ends_with;
 
 /**
  * @implements Rule<ClassLike>

src/Rules/Explicit/NoProtectedClassStmtRule.php

@@ -80,7 +80,7 @@ private function shouldSkipClassMethod(ClassMethod|ClassConst|Property $classStm
         }
 
         // PHPUnit test methods
-        if (in_array($classStmt->name->toString(), [MethodName::SET_UP, MethodName::TEAR_DOWN])) {
+        if (in_array($classStmt->name->toString(), [MethodName::SET_UP, MethodName::TEAR_DOWN], true)) {
             return true;
         }
 

src/Rules/NoDynamicNameRule.php

@@ -16,6 +16,7 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
+use PHPStan\Type\UnionType;
 use Symplify\PHPStanRules\Enum\RuleIdentifier;
 use Symplify\PHPStanRules\TypeAnalyzer\CallableTypeAnalyzer;
 
@@ -36,7 +37,7 @@ public function __construct(
     public function getNodeType(): string
     {
         // trick to allow multiple node types
-        return Node::class;
+        return Expr::class;
     }
 
     public function processNode(Node $node, Scope $scope): array
@@ -54,6 +55,11 @@ public function processNode(Node $node, Scope $scope): array
                 return [];
             }
 
+            $classType = $scope->getType($node->class);
+            if ($classType instanceof UnionType && $classType->getObjectClassReflections() !== []) {
+                return [];
+            }
+
             $ruleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
                 ->identifier(RuleIdentifier::NO_DYNAMIC_NAME)
                 ->build();

src/Rules/Rector/NoIntegerRefactorReturnRule.php

@@ -98,7 +98,7 @@ private function findUsedNodeVisitorConstantNames(ClassMethod $classMethod): arr
                 return null;
             }
 
-            if (! in_array($subNode->class->toString(), [NodeVisitor::class, NodeTraverser::class])) {
+            if (! in_array($subNode->class->toString(), [NodeVisitor::class, NodeTraverser::class], true)) {
                 return null;
             }
 

src/Rules/StringFileAbsolutePathExistsRule.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Symplify\PHPStanRules\Rules;
 
 use PhpParser\Node;

src/Rules/Symfony/ConfigClosure/NoDuplicateArgAutowireByTypeRule.php

@@ -105,7 +105,7 @@ public function processNode(Node $node, Scope $scope): array
         }
 
         // 2. special case for string known values
-        if ($referenceExpr instanceof String_ && in_array($referenceExpr->value, self::NAMED_AUTOWIRED_TYPES)) {
+        if ($referenceExpr instanceof String_ && in_array($referenceExpr->value, self::NAMED_AUTOWIRED_TYPES, true)) {
             $ruleError = RuleErrorBuilder::message(sprintf(self::ERROR_MESSAGE, $referenceExpr->value))
                 ->identifier(SymfonyRuleIdentifier::NO_DUPLICATE_ARG_AUTOWIRE_BY_TYPE)
                 ->line($referenceFuncCall->getStartLine())

src/Symfony/ConfigClosure/SymfonyServiceReferenceFunctionAnalyzer.php

@@ -23,9 +23,13 @@ public static function isReferenceCall(Expr $expr): bool
 
         $functionName = $expr->name->toString();
 
-        return in_array($functionName, [
-            SymfonyFunctionName::REF,
-            SymfonyFunctionName::SERVICE,
-        ]);
+        return in_array(
+            $functionName,
+            [
+                SymfonyFunctionName::REF,
+                SymfonyFunctionName::SERVICE,
+            ],
+            true
+        );
     }
 }

tests/Rules/NoDynamicNameRule/Fixture/SkipConstantLookupOnKnownType.php

@@ -0,0 +1,23 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\NoDynamicNameRule\Fixture;
+
+use Symplify\PHPStanRules\Tests\Rules\NoDynamicNameRule\Source\SomeClassConstantA;
+use Symplify\PHPStanRules\Tests\Rules\NoDynamicNameRule\Source\SomeClassConstantB;
+
+final class SkipConstantLookupOnKnownType
+{
+    public function run()
+    {
+        $objectOfKnownType = $this->getObject();
+        if ($objectOfKnownType::MY_CONSTANT === 3) {
+            echo "a";
+        }
+    }
+
+    private function getObject():SomeClassConstantA|SomeClassConstantB {
+        return rand(0,1) ? new SomeClassConstantA() : new SomeClassConstantB();
+    }
+}

tests/Rules/NoDynamicNameRule/NoDynamicNameRuleTest.php

@@ -11,10 +11,13 @@
 use PHPUnit\Framework\Attributes\DataProvider;
 use Symplify\PHPStanRules\Rules\NoDynamicNameRule;
 
+/**
+ * @extends RuleTestCase<NoDynamicNameRule>
+ */
 final class NoDynamicNameRuleTest extends RuleTestCase
 {
     /**
-     * @param array<int, array<string|int>> $expectedErrorMessagesWithLines
+     * @param list<array{string, int, 2?: string|null}> $expectedErrorMessagesWithLines
      */
     #[DataProvider('provideData')]
     public function testRule(string $filePath, array $expectedErrorMessagesWithLines): void
@@ -42,6 +45,7 @@ public static function provideData(): Iterator
         yield [__DIR__ . '/Fixture/SkipMagicGet.php', []];
         yield [__DIR__ . '/Fixture/SkipCallableUnion.php', []];
         yield [__DIR__ . '/Fixture/SkipNullableClosure.php', []];
+        yield [__DIR__ . '/Fixture/SkipConstantLookupOnKnownType.php', []];
         yield [__DIR__ . '/Fixture/SkipImmediatelyInvokedFunctionExpression.php', []];
     }
 

tests/Rules/NoDynamicNameRule/Source/SomeClassConstantA.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\NoDynamicNameRule\Source;
+
+final class SomeClassConstantA
+{
+    const MY_CONSTANT = 1;
+}

tests/Rules/NoDynamicNameRule/Source/SomeClassConstantB.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\NoDynamicNameRule\Source;
+
+final class SomeClassConstantB
+{
+    const MY_CONSTANT = 2;
+}