Conversation
What was broken Manual reviewer cards in the new Work Manager opened with public review opportunity disabled for dev challenges even when the default reviewer metadata enabled it. Root cause The work app dropped shouldOpenOpportunity while normalizing default reviewers, and new manual reviewer rows fell back to false. What was changed Added shouldOpenOpportunity to the work default reviewer model and preserved it in default reviewer fetch normalization. Updated manual reviewer row creation to honor the fetched default public review opportunity flag. Tests added/updated Added a challenges.service test covering shouldOpenOpportunity normalization. Added a HumanReviewTab test covering the checked default state after adding a reviewer.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Manual reviewer cards in the new Work Manager opened with public review opportunity disabled for dev challenges even when the default reviewer metadata enabled it.
Root cause
The work app dropped shouldOpenOpportunity while normalizing default reviewers, and new manual reviewer rows fell back to false.
What was changed
Added shouldOpenOpportunity to the work default reviewer model and preserved it in default reviewer fetch normalization.
Updated manual reviewer row creation to honor the fetched default public review opportunity flag.
Any added/updated tests
Added a challenges.service test covering shouldOpenOpportunity normalization.
Added a HumanReviewTab test covering the checked default state after adding a reviewer.