PM-4631: preserve default public review opportunity

src/apps/work/src/lib/models/Reviewer.model.ts

@@ -43,6 +43,7 @@ export interface DefaultReviewer {
     phaseId?: string
     roleId?: string
     scorecardId?: string
+    shouldOpenOpportunity?: boolean
 }
 
 export interface ScorecardFilters {

src/apps/work/src/lib/services/challenges.service.spec.ts

@@ -1,7 +1,13 @@
 /* eslint-disable import/no-extraneous-dependencies, ordered-imports/ordered-imports */
-import { xhrGetPaginatedAsync } from '~/libs/core'
+import {
+    xhrGetAsync,
+    xhrGetPaginatedAsync,
+} from '~/libs/core'
 
-import { fetchChallenges } from './challenges.service'
+import {
+    fetchChallenges,
+    fetchDefaultReviewers,
+} from './challenges.service'
 
 jest.mock('~/apps/review/src/lib/services/file-upload.service', () => ({
     uploadReviewAttachment: jest.fn(),
@@ -86,3 +92,36 @@ describe('fetchChallenges', () => {
             )
     })
 })
+
+describe('fetchDefaultReviewers', () => {
+    beforeEach(() => {
+        jest.clearAllMocks()
+    })
+
+    it('preserves shouldOpenOpportunity from the API response', async () => {
+        const mockedGet = xhrGetAsync as jest.Mock
+
+        mockedGet.mockResolvedValue([
+            {
+                isMemberReview: true,
+                memberReviewerCount: 1,
+                phaseId: 'phase-1',
+                roleId: 'role-1',
+                scorecardId: 'scorecard-1',
+                shouldOpenOpportunity: true,
+            },
+        ])
+
+        await expect(fetchDefaultReviewers('type-1', 'track-1'))
+            .resolves.toEqual([
+                {
+                    isMemberReview: true,
+                    memberReviewerCount: 1,
+                    phaseId: 'phase-1',
+                    roleId: 'role-1',
+                    scorecardId: 'scorecard-1',
+                    shouldOpenOpportunity: true,
+                },
+            ])
+    })
+})

src/apps/work/src/lib/services/challenges.service.ts

@@ -378,6 +378,7 @@ function normalizeDefaultReviewer(
         phaseId: toOptionalString(reviewer.phaseId),
         roleId: toOptionalString(reviewer.roleId),
         scorecardId: toOptionalString((reviewer as Record<string, unknown>).scorecardId),
+        shouldOpenOpportunity: toOptionalBoolean((reviewer as Record<string, unknown>).shouldOpenOpportunity),
     }
 }
 

src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ReviewersField/HumanReviewTab.spec.tsx

@@ -1,5 +1,6 @@
 /* eslint-disable import/no-extraneous-dependencies, ordered-imports/ordered-imports */
 import {
+    fireEvent,
     render,
     screen,
     waitFor,
@@ -232,6 +233,52 @@ describe('HumanReviewTab', () => {
             .toBeNull()
     })
 
+    it('checks public review opportunity by default when the default reviewer opens it', async () => {
+        mockedFetchDefaultReviewers.mockResolvedValue([
+            {
+                isMemberReview: true,
+                memberReviewerCount: 1,
+                phaseId: 'phase-1',
+                roleId: 'role-1',
+                scorecardId: 'scorecard-1',
+                shouldOpenOpportunity: true,
+            },
+        ])
+        mockedFetchScorecards.mockResolvedValue([
+            {
+                id: 'scorecard-1',
+                name: 'Scorecard 1',
+                phaseId: 'phase-1',
+            },
+        ])
+
+        render(
+            <TestHarness
+                defaultValues={{
+                    reviewers: [],
+                }}
+            />,
+        )
+
+        await waitFor(() => {
+            expect(mockedFetchDefaultReviewers)
+                .toHaveBeenCalledWith('type-1', 'track-1')
+        })
+        await waitFor(() => {
+            expect((screen.getByRole('button', { name: 'Add reviewer' }) as HTMLButtonElement).disabled)
+                .toBe(false)
+        })
+
+        fireEvent.click(screen.getByRole('button', { name: 'Add reviewer' }))
+
+        await waitFor(() => {
+            expect((
+                screen.getByRole('checkbox', { name: 'Open public review opportunity' }) as HTMLInputElement
+            ).checked)
+                .toBe(true)
+        })
+    })
+
     it('shows only unassigned non-submission phases on each reviewer card', () => {
         render(
             <TestHarness

src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ReviewersField/HumanReviewTab.tsx

@@ -344,7 +344,7 @@ function mapDefaultReviewerToReviewer(
         roleId: defaultReviewer?.roleId,
         scorecardId: defaultReviewer?.scorecardId,
         shouldOpenOpportunity: memberReview
-            ? false
+            ? (defaultReviewer?.shouldOpenOpportunity ?? false)
             : undefined,
     }
 }