Conversation
What was broken Task challenges in the new Work Manager could not be saved without selecting a reviewer because the field was marked and validated as mandatory. Root cause The work challenge editor enforced a required rule for the reviewer field on task challenges with internal review and rendered the task reviewer autocomplete as required in the UI. What was changed Removed the task reviewer required validation from the challenge editor schema, removed the required marker from the task reviewer autocomplete, and updated the challenge editor README to match the optional behavior. Any added/updated tests Updated the challenge editor schema spec to confirm task internal review no longer requires a reviewer and updated the ReviewTypeField spec to assert the task reviewer autocomplete is not marked required.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Task challenges in the new Work Manager could not be saved without selecting a reviewer because the field was marked and validated as mandatory.
Root cause
The work challenge editor enforced a required rule for the reviewer field on task challenges with internal review and rendered the task reviewer autocomplete as required in the UI.
What was changed
Removed the task reviewer required validation from the challenge editor schema, removed the required marker from the task reviewer autocomplete, and updated the challenge editor README to match the optional behavior.
Any added/updated tests
Updated the challenge editor schema spec to confirm task internal review no longer requires a reviewer and updated the ReviewTypeField spec to assert the task reviewer autocomplete is not marked required.