Conversation
What was broken The manual AI workflow editor in the new work manager UI showed the "Use as gating workflow" checkbox without the helper definition that exists in the legacy work manager. That left both checked and unchecked states unclear. Root cause The platform-ui rewrite kept the checkbox control but did not carry over the explanatory helper copy from the legacy manual workflow card. What was changed Added persistent helper text under the gating checkbox in AiReviewTab so every workflow explains that submissions below the threshold are locked. When the workflow is marked as gating, the helper also adds the "Pass/fail gate." copy used by the legacy work manager. Added aria-describedby wiring and small styling updates so the helper text is associated with the checkbox and laid out cleanly. Any added/updated tests Updated AiReviewTab.spec.tsx to cover both checked and unchecked gating workflow states. Validated with yarn test:no-watch --runInBand --runTestsByPath src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ReviewersField/AiReviewTab.spec.tsx, yarn lint, and yarn run build. yarn test:no-watch --runInBand still fails on pre-existing wallet-admin tests in src/apps/wallet-admin/src/home/tabs/payments/PaymentsListView.spec.tsx, and the same failures reproduce on an untouched dev worktree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The manual AI workflow editor in the new work manager UI showed the "Use as gating workflow" checkbox without the helper definition that exists in the legacy work manager.
That left both checked and unchecked states unclear.
Root cause
The platform-ui rewrite kept the checkbox control but did not carry over the explanatory helper copy from the legacy manual workflow card.
What was changed
Added persistent helper text under the gating checkbox in AiReviewTab so every workflow explains that submissions below the threshold are locked.
When the workflow is marked as gating, the helper also adds the "Pass/fail gate." copy used by the legacy work manager.
Added aria-describedby wiring and small styling updates so the helper text is associated with the checkbox and laid out cleanly.
Any added/updated tests
Updated AiReviewTab.spec.tsx to cover both checked and unchecked gating workflow states.
Validated with yarn test:no-watch --runInBand --runTestsByPath src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ReviewersField/AiReviewTab.spec.tsx, yarn lint, and yarn run build.
yarn test:no-watch --runInBand still fails on pre-existing wallet-admin tests in src/apps/wallet-admin/src/home/tabs/payments/PaymentsListView.spec.tsx, and the same failures reproduce on an untouched dev worktree.