Skip to content

PM-4710: restore gating workflow guidance#1643

Merged
jmgasper merged 3 commits intodevfrom
PM-4710
Apr 6, 2026
Merged

PM-4710: restore gating workflow guidance#1643
jmgasper merged 3 commits intodevfrom
PM-4710

Conversation

@jmgasper
Copy link
Copy Markdown
Collaborator

@jmgasper jmgasper commented Apr 3, 2026

What was broken
The manual AI workflow editor in the new work manager UI showed the "Use as gating workflow" checkbox without the helper definition that exists in the legacy work manager.
That left both checked and unchecked states unclear.

Root cause
The platform-ui rewrite kept the checkbox control but did not carry over the explanatory helper copy from the legacy manual workflow card.

What was changed
Added persistent helper text under the gating checkbox in AiReviewTab so every workflow explains that submissions below the threshold are locked.
When the workflow is marked as gating, the helper also adds the "Pass/fail gate." copy used by the legacy work manager.
Added aria-describedby wiring and small styling updates so the helper text is associated with the checkbox and laid out cleanly.

Any added/updated tests
Updated AiReviewTab.spec.tsx to cover both checked and unchecked gating workflow states.
Validated with yarn test:no-watch --runInBand --runTestsByPath src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ReviewersField/AiReviewTab.spec.tsx, yarn lint, and yarn run build.
yarn test:no-watch --runInBand still fails on pre-existing wallet-admin tests in src/apps/wallet-admin/src/home/tabs/payments/PaymentsListView.spec.tsx, and the same failures reproduce on an untouched dev worktree.


Open with Devin

What was broken
The manual AI workflow editor in the new work manager UI showed the "Use as gating workflow" checkbox without the helper definition that exists in the legacy work manager.
That left both checked and unchecked states unclear.

Root cause
The platform-ui rewrite kept the checkbox control but did not carry over the explanatory helper copy from the legacy manual workflow card.

What was changed
Added persistent helper text under the gating checkbox in AiReviewTab so every workflow explains that submissions below the threshold are locked.
When the workflow is marked as gating, the helper also adds the "Pass/fail gate." copy used by the legacy work manager.
Added aria-describedby wiring and small styling updates so the helper text is associated with the checkbox and laid out cleanly.

Any added/updated tests
Updated AiReviewTab.spec.tsx to cover both checked and unchecked gating workflow states.
Validated with yarn test:no-watch --runInBand --runTestsByPath src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ReviewersField/AiReviewTab.spec.tsx, yarn lint, and yarn run build.
yarn test:no-watch --runInBand still fails on pre-existing wallet-admin tests in src/apps/wallet-admin/src/home/tabs/payments/PaymentsListView.spec.tsx, and the same failures reproduce on an untouched dev worktree.
@jmgasper jmgasper requested a review from kkartunov as a code owner April 3, 2026 15:47
devin-ai-integration[bot]

This comment was marked as resolved.

@jmgasper jmgasper merged commit d5fa4a0 into dev Apr 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant