Conversation
What was broken Wallet-admin engagement payment details showed the Payment Creator field in the top summary block below the handle. QA expected that field inside the Work Log / Manager Inputs section of the Payment Details modal. Root cause (if identifiable) The earlier fix added the new field to the summary section instead of the work-log section, and the wallet-admin test only checked that the creator handle rendered somewhere. What was changed Moved the wallet-admin Payment Creator field into the Work Log / Manager Inputs section. Updated the wallet-admin payment-view test so it asserts the field is rendered inside that section and only appears once. Any added/updated tests Updated src/apps/wallet-admin/src/lib/components/payment-view/PaymentView.spec.tsx to verify Payment Creator renders inside Work Log / Manager Inputs.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Wallet-admin engagement payments showed Payment Creator below the assignee handle in the top summary area.
QA expected the field inside the Work Log / Manager Inputs section of the Payment Details modal.
Root cause (if identifiable)
The earlier fix added the new field to the summary block instead of the work-log section, and the wallet-admin test only asserted that the creator handle rendered somewhere.
What was changed
Moved the wallet-admin Payment Creator field into the Work Log / Manager Inputs section.
Updated the wallet-admin spec so it asserts the field is rendered inside that section and only appears once.
Any added/updated tests
Updated src/apps/wallet-admin/src/lib/components/payment-view/PaymentView.spec.tsx to verify Payment Creator renders inside Work Log / Manager Inputs.
Ran yarn test:no-watch --runInBand --runTestsByPath src/apps/wallet-admin/src/lib/components/payment-view/PaymentView.spec.tsx src/apps/work/src/lib/components/PaymentHistoryModal/PaymentHistoryModal.spec.tsx.
Ran yarn lint and yarn run build.