Skip to content

PM-4819: Move wallet-admin payment creator into work log section #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmgasper merged 1 commit into from
Apr 10, 2026
Merged

PM-4819: Move wallet-admin payment creator into work log section #1713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/apps/wallet-admin/src/lib/components/payment-view/PaymentView.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
render,
screen,
waitFor,
within,
} from '@testing-library/react'

import { Winning } from '../../models/WinningDetail'
Expand Down Expand Up @@ -122,15 +123,31 @@ describe('PaymentView', () => {

expect(await screen.findByRole('heading', { name: 'Engagement Details' }))
.toBeTruthy()
expect(await screen.findByText('copilot-manager'))
.toBeTruthy()
await waitFor(() => {
expect(screen.getAllByText('43.75'))
.toHaveLength(2)
})
expect(await screen.findByText(/Completed sprint support and bug triage\./))
.toBeTruthy()

const workLogHeading = await screen.findByRole('heading', {
name: 'Work Log / Manager Inputs',
})
const workLogSection = workLogHeading.parentElement

if (!workLogSection) {
throw new Error('Expected work log section to be rendered.')
}

expect(screen.getAllByText('Payment Creator'))
.toHaveLength(1)
expect(within(workLogSection)
.getByText('Payment Creator'))
.toBeTruthy()
expect(within(workLogSection)
.getByText('copilot-manager'))
.toBeTruthy()

const descriptionLink = await screen.findByRole('link', {
name: 'Wipro - US Foods - Week Ending: Mar 21, 2026',
})
Expand Down
17 changes: 6 additions & 11 deletions src/apps/wallet-admin/src/lib/components/payment-view/PaymentView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,17 +164,6 @@ const PaymentView: React.FC<PaymentViewProps> = (props: PaymentViewProps) => {
<span className={styles.label}>Handle</span>
<p className={styles.value}>{props.payment.handle}</p>
</div>
{isEngagementPayment && (
<div className={styles.infoItem}>
<span className={styles.label}>Payment Creator</span>
<p className={styles.value}>
{isPaymentDetailsLoading
? 'Loading...'
: formatOptionalText(paymentDetails?.paymentCreatorHandle)}
</p>
</div>
)}

<div className={styles.infoItem}>
<span className={styles.label}>Type</span>
<p className={styles.value}>{props.payment.type}</p>
Expand Down Expand Up @@ -306,6 +295,12 @@ const PaymentView: React.FC<PaymentViewProps> = (props: PaymentViewProps) => {
{renderOptionalLinkedText(paymentDetails?.workLog?.remarks)}
</p>
</div>
<div className={styles.infoItem}>
<span className={styles.label}>Payment Creator</span>
<p className={styles.value}>
{formatOptionalText(paymentDetails?.paymentCreatorHandle)}
</p>
</div>
</div>
)}
</div>
Expand Down
Loading