Draft
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Draft
Merging this PR will degrade performance by 18.01%
Performance Changes
Comparing 
Footnotes
|
Signed-off-by: Nicholas Gates <nick@nickgates.com>
gatesn
force-pushed
the
ngates/aggregate-fns-mean
branch
from
1f43f0b to
ade8613
Compare
Deploying vortex-bench with
|
| Latest commit: |
ade8613
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6439fe4d.vortex-93b.pages.dev |
| Branch Preview URL: | https://ngates-aggregate-fns-mean.vortex-93b.pages.dev |
gatesn
commented
Feb 28, 2026
| if !input_dtype.is_int() && !input_dtype.is_float() { | ||
| vortex_bail!("Mean requires numeric input, got {}", input_dtype); | ||
| } | ||
| Ok(DType::Primitive(PType::F64, Nullability::Nullable)) |
Contributor
Author
There was a problem hiding this comment.
Why is this nullable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mean AggregateFn