Skip to content

Aggregate Fns: Sum#6723

Draft
gatesn wants to merge 2 commits intongates/aggregate-fns-meanfrom
ngates/aggregate-fns-sum
Draft

Aggregate Fns: Sum#6723
gatesn wants to merge 2 commits intongates/aggregate-fns-meanfrom
ngates/aggregate-fns-sum

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Feb 28, 2026

Sum AggregateFn

Copy link
Contributor Author

gatesn commented Feb 28, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Feb 28, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 28, 2026

Merging this PR will improve performance by 25.32%

⚡ 4 improved benchmarks
✅ 950 untouched benchmarks
⏩ 1466 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bench_many_nulls[0.5] 379.1 µs 343.1 µs +10.48%
Simulation bench_many_nulls[0.9] 547.1 µs 481.9 µs +13.52%
Simulation take_map[(0.1, 0.1)] 1,032.1 µs 913.9 µs +12.94%
Simulation take_map[(0.1, 1.0)] 4.4 ms 3.5 ms +25.32%

Comparing ngates/aggregate-fns-sum (dc29d55) with ngates/aggregate-fns-mean (ade8613)

Open in CodSpeed

Footnotes

  1. 1466 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gatesn gatesn mentioned this pull request Feb 28, 2026
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn force-pushed the ngates/aggregate-fns-sum branch from 925f49d to dc29d55 Compare February 28, 2026 19:45
@gatesn gatesn force-pushed the ngates/aggregate-fns-mean branch from 1f43f0b to ade8613 Compare February 28, 2026 19:45
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 28, 2026

Deploying vortex-bench with  Cloudflare Pages  Cloudflare Pages

Latest commit: dc29d55
Status: ✅  Deploy successful!
Preview URL: https://d98f7a8b.vortex-93b.pages.dev
Branch Preview URL: https://ngates-aggregate-fns-sum.vortex-93b.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant