fix(avm)!: remove unused dc selector#21314
Merged
IlyasRidhuan merged 1 commit intomerge-train/avmfrom Mar 13, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
IlyasRidhuan
force-pushed
the
ir/03-10-fix_avm_remove_unused_dc_selector
branch
from
f0d7cd9 to
d2d7df9
Compare
IlyasRidhuan
force-pushed
the
ir/03-05-fix_avm_precomputed_pre-audit
branch
from
eb47423 to
1eef20b
Compare
IlyasRidhuan
requested review from
Maddiaa0,
fcarreiro and
jeanmon
as code owners
jeanmon
approved these changes
Mar 10, 2026
Contributor
jeanmon
left a comment
jeanmon
left a comment
There was a problem hiding this comment.
Sounds good.
Is there a way to have cpp complain about WireOpCode_DC_SELECTORS being intialized with arrays of size 17 even though the length was declared 18?
IlyasRidhuan
force-pushed
the
ir/03-10-fix_avm_remove_unused_dc_selector
branch
from
d2d7df9 to
d554f25
Compare
IlyasRidhuan
force-pushed
the
ir/03-05-fix_avm_precomputed_pre-audit
branch
from
1eef20b to
a57e34a
Compare
IlyasRidhuan
force-pushed
the
ir/03-05-fix_avm_precomputed_pre-audit
branch
from
a57e34a to
045a778
Compare
IlyasRidhuan
force-pushed
the
ir/03-10-fix_avm_remove_unused_dc_selector
branch
2 times, most recently
from
2fa6dcf to
33d6afa
Compare
IlyasRidhuan
force-pushed
the
ir/03-05-fix_avm_precomputed_pre-audit
branch
from
045a778 to
d9b5536
Compare
Base automatically changed from
ir/03-05-fix_avm_precomputed_pre-audit
to
merge-train/avm
March 13, 2026 13:29
IlyasRidhuan
force-pushed
the
ir/03-10-fix_avm_remove_unused_dc_selector
branch
from
33d6afa to
22e7148
Compare
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
BEGIN_COMMIT_OVERRIDE chore: contract_instance_retrieval pre-audit avm (#21220) fix(avm)!: bytecode hashing - internal audit (#21152) fix(avm)!: precomputed pre-audit (#21313) fix(avm)!: remove unused dc selector (#21314) fix(avm)!: Pre audit public data check / squash (#21266) chore(avm): Pre audit misc opcodes (#21521) END_COMMIT_OVERRIDE
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sel_op_dc_17was unused since #13971 and can be safely removed.