fix(avm): keccak pre-audit#21486
Merged
IlyasRidhuan merged 1 commit intomerge-train/avmfrom Mar 19, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
IlyasRidhuan
force-pushed
the
ir/03-13-fix_avm_keccak_pre-audit
branch
2 times, most recently
from
672d5db to
af081ec
Compare
IlyasRidhuan
force-pushed
the
ir/03-10-fix_avm_remove_unused_dc_selector
branch
from
d554f25 to
2fa6dcf
Compare
IlyasRidhuan
changed the base branch from
ir/03-10-fix_avm_remove_unused_dc_selector
to
graphite-base/21486
IlyasRidhuan
force-pushed
the
ir/03-13-fix_avm_keccak_pre-audit
branch
from
af081ec to
8415259
Compare
IlyasRidhuan
force-pushed
the
graphite-base/21486
branch
from
2fa6dcf to
33d6afa
Compare
IlyasRidhuan
changed the base branch from
graphite-base/21486
to
ir/03-10-fix_avm_remove_unused_dc_selector
IlyasRidhuan
force-pushed
the
ir/03-10-fix_avm_remove_unused_dc_selector
branch
from
33d6afa to
22e7148
Compare
IlyasRidhuan
force-pushed
the
ir/03-13-fix_avm_keccak_pre-audit
branch
from
8415259 to
a7d80db
Compare
Base automatically changed from
ir/03-10-fix_avm_remove_unused_dc_selector
to
merge-train/avm
March 13, 2026 13:52
IlyasRidhuan
force-pushed
the
ir/03-13-fix_avm_keccak_pre-audit
branch
3 times, most recently
from
1478ef6 to
ca9c17e
Compare
IlyasRidhuan
force-pushed
the
ir/03-13-fix_avm_keccak_pre-audit
branch
3 times, most recently
from
50b0d32 to
0a38e7c
Compare
IlyasRidhuan
requested review from
Maddiaa0,
fcarreiro and
jeanmon
as code owners
IlyasRidhuan
force-pushed
the
ir/03-13-fix_avm_keccak_pre-audit
branch
from
0a38e7c to
b54fe00
Compare
jeanmon
reviewed
Mar 18, 2026
barretenberg/cpp/src/barretenberg/vm2/tracegen/keccakf1600_trace.hpp
Outdated
Show resolved
Hide resolved
jeanmon
approved these changes
Mar 18, 2026
Contributor
jeanmon
left a comment
jeanmon
left a comment
There was a problem hiding this comment.
LGTM. I just have one comment on doxygen docu being in .hpp instead of .cpp
IlyasRidhuan
force-pushed
the
ir/03-13-fix_avm_keccak_pre-audit
branch
from
b54fe00 to
db4424a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly docs update for keccak.