fix(avm)!: reduce keccakf cols#21641
Open
IlyasRidhuan wants to merge 1 commit into03-18-fix_avm_add_std_multi-row_computation_constraintfrom
Open
fix(avm)!: reduce keccakf cols#21641IlyasRidhuan wants to merge 1 commit into03-18-fix_avm_add_std_multi-row_computation_constraintfrom
IlyasRidhuan wants to merge 1 commit into03-18-fix_avm_add_std_multi-row_computation_constraintfrom
Conversation
This was referenced Mar 16, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
IlyasRidhuan
force-pushed
the
03-17-fix_avm_reduce_keccakf_cols
branch
from
2606e9f to
4785eb4
Compare
IlyasRidhuan
force-pushed
the
ir/03-13-fix_avm_keccak_pre-audit
branch
from
ca9c17e to
4d345b1
Compare
IlyasRidhuan
force-pushed
the
03-17-fix_avm_reduce_keccakf_cols
branch
from
4785eb4 to
78c7971
Compare
IlyasRidhuan
force-pushed
the
ir/03-13-fix_avm_keccak_pre-audit
branch
from
4d345b1 to
50b0d32
Compare
IlyasRidhuan
force-pushed
the
03-17-fix_avm_reduce_keccakf_cols
branch
from
78c7971 to
0dc2f9c
Compare
IlyasRidhuan
force-pushed
the
ir/03-13-fix_avm_keccak_pre-audit
branch
from
50b0d32 to
0a38e7c
Compare
IlyasRidhuan
force-pushed
the
03-17-fix_avm_reduce_keccakf_cols
branch
from
0dc2f9c to
92c6f37
Compare
IlyasRidhuan
changed the base branch from
ir/03-13-fix_avm_keccak_pre-audit
to
03-18-fix_avm_add_std_multi-row_computation_constraint
IlyasRidhuan
force-pushed
the
03-18-fix_avm_add_std_multi-row_computation_constraint
branch
from
716857c to
e199983
Compare
IlyasRidhuan
force-pushed
the
03-17-fix_avm_reduce_keccakf_cols
branch
from
92c6f37 to
97f7f6d
Compare
IlyasRidhuan
requested review from
Maddiaa0,
fcarreiro and
jeanmon
as code owners
jeanmon
reviewed
Mar 18, 2026
jeanmon
reviewed
Mar 18, 2026
jeanmon
reviewed
Mar 18, 2026
jeanmon
approved these changes
Mar 18, 2026
Contributor
jeanmon
left a comment
jeanmon
left a comment
There was a problem hiding this comment.
I approve to unblock but please adapt the proof based on my comments and consider other feedback (removing some unused aliases)
IlyasRidhuan
force-pushed
the
03-18-fix_avm_add_std_multi-row_computation_constraint
branch
2 times, most recently
from
736c793 to
85004f6
Compare
IlyasRidhuan
force-pushed
the
03-17-fix_avm_reduce_keccakf_cols
branch
from
97f7f6d to
c92f5d7
Compare
IlyasRidhuan
force-pushed
the
03-18-fix_avm_add_std_multi-row_computation_constraint
branch
from
85004f6 to
7e0654f
Compare
IlyasRidhuan
force-pushed
the
03-17-fix_avm_reduce_keccakf_cols
branch
from
c92f5d7 to
c3a2497
Compare
jeanmon
approved these changes
Mar 19, 2026
IlyasRidhuan
force-pushed
the
03-18-fix_avm_add_std_multi-row_computation_constraint
branch
from
7e0654f to
a878081
Compare
IlyasRidhuan
force-pushed
the
03-17-fix_avm_reduce_keccakf_cols
branch
from
c3a2497 to
a84a1d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes 29 columns and subrelations by optimising the way we constrain bitwise rotations.