Update Telemetry Key Normalization to Use Environment Variables#10788
Closed
Update Telemetry Key Normalization to Use Environment Variables#10788
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~8c709210ff, baseline=1.61.0-SNAPSHOT~93c3816062
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061916
Total [baseline] (8.888 s) : 0, 8888006
Agent [candidate] (1.058 s) : 0, 1057934
Total [candidate] (8.83 s) : 0, 8829709
section iast
Agent [baseline] (1.228 s) : 0, 1227835
Total [baseline] (9.571 s) : 0, 9570829
Agent [candidate] (1.231 s) : 0, 1231471
Total [candidate] (9.576 s) : 0, 9575615
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~8c709210ff, baseline=1.61.0-SNAPSHOT~93c3816062
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (630.282 ms) : 0, 630282
BytebuddyAgent [candidate] (628.996 ms) : 0, 628996
AgentMeter [baseline] (29.171 ms) : 0, 29171
AgentMeter [candidate] (29.167 ms) : 0, 29167
GlobalTracer [baseline] (257.416 ms) : 0, 257416
GlobalTracer [candidate] (257.251 ms) : 0, 257251
AppSec [baseline] (31.635 ms) : 0, 31635
AppSec [candidate] (31.631 ms) : 0, 31631
Debugger [baseline] (58.991 ms) : 0, 58991
Debugger [candidate] (58.79 ms) : 0, 58790
Remote Config [baseline] (594.082 µs) : 0, 594
Remote Config [candidate] (582.449 µs) : 0, 582
Telemetry [baseline] (8.652 ms) : 0, 8652
Telemetry [candidate] (8.661 ms) : 0, 8661
Flare Poller [baseline] (7.919 ms) : 0, 7919
Flare Poller [candidate] (5.68 ms) : 0, 5680
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (797.0 ms) : 0, 797000
BytebuddyAgent [candidate] (800.081 ms) : 0, 800081
AgentMeter [baseline] (11.322 ms) : 0, 11322
AgentMeter [candidate] (11.58 ms) : 0, 11580
GlobalTracer [baseline] (247.676 ms) : 0, 247676
GlobalTracer [candidate] (248.018 ms) : 0, 248018
IAST [baseline] (25.142 ms) : 0, 25142
IAST [candidate] (25.342 ms) : 0, 25342
AppSec [baseline] (26.425 ms) : 0, 26425
AppSec [candidate] (26.579 ms) : 0, 26579
Debugger [baseline] (62.827 ms) : 0, 62827
Debugger [candidate] (62.647 ms) : 0, 62647
Remote Config [baseline] (523.438 µs) : 0, 523
Remote Config [candidate] (524.696 µs) : 0, 525
Telemetry [baseline] (14.964 ms) : 0, 14964
Telemetry [candidate] (15.268 ms) : 0, 15268
Flare Poller [baseline] (4.672 ms) : 0, 4672
Flare Poller [candidate] (4.227 ms) : 0, 4227
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~8c709210ff, baseline=1.61.0-SNAPSHOT~93c3816062
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062727
Total [baseline] (11.116 s) : 0, 11116388
Agent [candidate] (1.057 s) : 0, 1056858
Total [candidate] (11.142 s) : 0, 11142223
section appsec
Agent [baseline] (1.258 s) : 0, 1257520
Total [baseline] (11.266 s) : 0, 11265731
Agent [candidate] (1.246 s) : 0, 1245839
Total [candidate] (11.166 s) : 0, 11166307
section iast
Agent [baseline] (1.234 s) : 0, 1234343
Total [baseline] (11.314 s) : 0, 11314205
Agent [candidate] (1.226 s) : 0, 1226382
Total [candidate] (11.321 s) : 0, 11321188
section profiling
Agent [baseline] (1.197 s) : 0, 1196542
Total [baseline] (11.07 s) : 0, 11069841
Agent [candidate] (1.182 s) : 0, 1182335
Total [candidate] (11.084 s) : 0, 11084368
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~8c709210ff, baseline=1.61.0-SNAPSHOT~93c3816062
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (629.403 ms) : 0, 629403
BytebuddyAgent [candidate] (627.567 ms) : 0, 627567
AgentMeter [baseline] (29.24 ms) : 0, 29240
AgentMeter [candidate] (29.073 ms) : 0, 29073
GlobalTracer [baseline] (257.624 ms) : 0, 257624
GlobalTracer [candidate] (256.666 ms) : 0, 256666
AppSec [baseline] (31.639 ms) : 0, 31639
AppSec [candidate] (31.519 ms) : 0, 31519
Debugger [baseline] (59.521 ms) : 0, 59521
Debugger [candidate] (59.286 ms) : 0, 59286
Remote Config [baseline] (598.825 µs) : 0, 599
Remote Config [candidate] (587.224 µs) : 0, 587
Telemetry [baseline] (8.683 ms) : 0, 8683
Telemetry [candidate] (8.633 ms) : 0, 8633
Flare Poller [baseline] (8.784 ms) : 0, 8784
Flare Poller [candidate] (6.428 ms) : 0, 6428
section appsec
crashtracking [baseline] (1.228 ms) : 0, 1228
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (666.249 ms) : 0, 666249
BytebuddyAgent [candidate] (658.786 ms) : 0, 658786
AgentMeter [baseline] (12.138 ms) : 0, 12138
AgentMeter [candidate] (12.071 ms) : 0, 12071
GlobalTracer [baseline] (260.446 ms) : 0, 260446
GlobalTracer [candidate] (257.991 ms) : 0, 257991
AppSec [baseline] (177.862 ms) : 0, 177862
AppSec [candidate] (177.03 ms) : 0, 177030
Debugger [baseline] (65.865 ms) : 0, 65865
Debugger [candidate] (65.471 ms) : 0, 65471
Remote Config [baseline] (572.414 µs) : 0, 572
Remote Config [candidate] (567.549 µs) : 0, 568
Telemetry [baseline] (9.056 ms) : 0, 9056
Telemetry [candidate] (9.021 ms) : 0, 9021
Flare Poller [baseline] (3.596 ms) : 0, 3596
Flare Poller [candidate] (3.591 ms) : 0, 3591
IAST [baseline] (24.062 ms) : 0, 24062
IAST [candidate] (23.906 ms) : 0, 23906
section iast
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (801.355 ms) : 0, 801355
BytebuddyAgent [candidate] (795.533 ms) : 0, 795533
AgentMeter [baseline] (11.575 ms) : 0, 11575
AgentMeter [candidate] (11.31 ms) : 0, 11310
GlobalTracer [baseline] (248.152 ms) : 0, 248152
GlobalTracer [candidate] (247.302 ms) : 0, 247302
AppSec [baseline] (26.638 ms) : 0, 26638
AppSec [candidate] (26.422 ms) : 0, 26422
Debugger [baseline] (65.035 ms) : 0, 65035
Debugger [candidate] (64.048 ms) : 0, 64048
Remote Config [baseline] (533.451 µs) : 0, 533
Remote Config [candidate] (528.482 µs) : 0, 528
Telemetry [baseline] (13.872 ms) : 0, 13872
Telemetry [candidate] (14.875 ms) : 0, 14875
Flare Poller [baseline] (4.532 ms) : 0, 4532
Flare Poller [candidate] (3.991 ms) : 0, 3991
IAST [baseline] (25.329 ms) : 0, 25329
IAST [candidate] (25.134 ms) : 0, 25134
section profiling
ProfilingAgent [baseline] (94.172 ms) : 0, 94172
ProfilingAgent [candidate] (93.791 ms) : 0, 93791
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.167 ms) : 0, 1167
BytebuddyAgent [baseline] (691.855 ms) : 0, 691855
BytebuddyAgent [candidate] (682.772 ms) : 0, 682772
AgentMeter [baseline] (8.767 ms) : 0, 8767
AgentMeter [candidate] (8.62 ms) : 0, 8620
GlobalTracer [baseline] (218.107 ms) : 0, 218107
GlobalTracer [candidate] (215.548 ms) : 0, 215548
AppSec [baseline] (32.475 ms) : 0, 32475
AppSec [candidate] (31.955 ms) : 0, 31955
Debugger [baseline] (64.547 ms) : 0, 64547
Debugger [candidate] (63.09 ms) : 0, 63090
Remote Config [baseline] (591.298 µs) : 0, 591
Remote Config [candidate] (594.596 µs) : 0, 595
Telemetry [baseline] (9.892 ms) : 0, 9892
Telemetry [candidate] (9.77 ms) : 0, 9770
Flare Poller [baseline] (3.465 ms) : 0, 3465
Flare Poller [candidate] (4.28 ms) : 0, 4280
Profiling [baseline] (94.744 ms) : 0, 94744
Profiling [candidate] (94.352 ms) : 0, 94352
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~8c709210ff, baseline=1.61.0-SNAPSHOT~93c3816062
dateFormat X
axisFormat %s
section baseline
no_agent (1.173 ms) : 1162, 1184
. : milestone, 1173,
iast (3.241 ms) : 3196, 3286
. : milestone, 3241,
iast_FULL (5.679 ms) : 5623, 5734
. : milestone, 5679,
iast_GLOBAL (3.441 ms) : 3390, 3492
. : milestone, 3441,
profiling (2.023 ms) : 2005, 2040
. : milestone, 2023,
tracing (1.81 ms) : 1793, 1827
. : milestone, 1810,
section candidate
no_agent (1.191 ms) : 1179, 1203
. : milestone, 1191,
iast (3.192 ms) : 3148, 3235
. : milestone, 3192,
iast_FULL (5.687 ms) : 5629, 5744
. : milestone, 5687,
iast_GLOBAL (3.653 ms) : 3592, 3714
. : milestone, 3653,
profiling (2.246 ms) : 2226, 2266
. : milestone, 2246,
tracing (1.776 ms) : 1760, 1791
. : milestone, 1776,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~8c709210ff, baseline=1.61.0-SNAPSHOT~93c3816062
dateFormat X
axisFormat %s
section baseline
no_agent (18.206 ms) : 18018, 18394
. : milestone, 18206,
appsec (18.693 ms) : 18501, 18885
. : milestone, 18693,
code_origins (17.605 ms) : 17428, 17782
. : milestone, 17605,
iast (18.05 ms) : 17869, 18231
. : milestone, 18050,
profiling (18.68 ms) : 18492, 18867
. : milestone, 18680,
tracing (17.599 ms) : 17426, 17773
. : milestone, 17599,
section candidate
no_agent (17.995 ms) : 17814, 18175
. : milestone, 17995,
appsec (18.447 ms) : 18259, 18635
. : milestone, 18447,
code_origins (17.667 ms) : 17488, 17846
. : milestone, 17667,
iast (18.775 ms) : 18584, 18965
. : milestone, 18775,
profiling (18.393 ms) : 18213, 18573
. : milestone, 18393,
tracing (17.529 ms) : 17354, 17704
. : milestone, 17529,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~8c709210ff, baseline=1.61.0-SNAPSHOT~93c3816062
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.521 ms) : 2465, 2576
. : milestone, 2521,
iast (2.251 ms) : 2182, 2320
. : milestone, 2251,
iast_GLOBAL (2.299 ms) : 2229, 2369
. : milestone, 2299,
profiling (2.095 ms) : 2040, 2150
. : milestone, 2095,
tracing (2.062 ms) : 2009, 2116
. : milestone, 2062,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.741 ms) : 3525, 3958
. : milestone, 3741,
iast (2.258 ms) : 2189, 2328
. : milestone, 2258,
iast_GLOBAL (2.301 ms) : 2231, 2371
. : milestone, 2301,
profiling (2.091 ms) : 2035, 2146
. : milestone, 2091,
tracing (2.058 ms) : 2004, 2111
. : milestone, 2058,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~8c709210ff, baseline=1.61.0-SNAPSHOT~93c3816062
dateFormat X
axisFormat %s
section baseline
no_agent (15.511 s) : 15511000, 15511000
. : milestone, 15511000,
appsec (14.904 s) : 14904000, 14904000
. : milestone, 14904000,
iast (18.263 s) : 18263000, 18263000
. : milestone, 18263000,
iast_GLOBAL (17.522 s) : 17522000, 17522000
. : milestone, 17522000,
profiling (14.98 s) : 14980000, 14980000
. : milestone, 14980000,
tracing (14.997 s) : 14997000, 14997000
. : milestone, 14997000,
section candidate
no_agent (15.558 s) : 15558000, 15558000
. : milestone, 15558000,
appsec (15.087 s) : 15087000, 15087000
. : milestone, 15087000,
iast (18.354 s) : 18354000, 18354000
. : milestone, 18354000,
iast_GLOBAL (17.991 s) : 17991000, 17991000
. : milestone, 17991000,
profiling (14.844 s) : 14844000, 14844000
. : milestone, 14844000,
tracing (14.899 s) : 14899000, 14899000
. : milestone, 14899000,
|
5 tasks
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
One major pain-point for developers is that they need to manually enable intake to accept new configurations added to the tracers in order to receive telemetry for these newly added configs. The configuration team would like to automate this process for developers, automatically opening PRs in dd-go to add telemetry normalization in intake when new configurations are added to any of the dd-trace* libraries.
Since each tracer sends telemetry keys in a different format, we need to first standardize what is being sent. The common format among all tracers is environment variables. Thus, this PR updates the normalization of telemetry keys being sent from the current status (lowercase and
_) to using the environment variable version of the configurations.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.