ENG-1225: Discourse node migration simple settings

[sid597]

https://www.loom.com/share/9aa6f5f8815e41de92f21e14f7f5f855

demo video

changes done to following settings

"Key Image" — DiscourseNodeCanvasSettings.tsx

"Embedding Block Ref" — DiscourseNodeSuggestiveRules.tsx

"First Child" — DiscourseNodeSuggestiveRules.tsx

"Description" — NodeConfig.tsx

"Shortcut" — NodeConfig.tsx

"Tag" — NodeConfig.tsx

"Graph Overview" — NodeConfig.tsx

ENG-1225: Discourse node migration

Migrate personal settings text inputs

remove unnecessary checks zod takes care

migrate attributes overlay and suggestive rules

---

Summary by CodeRabbit

• Refactor
  • Migrated all settings storage from global to personal user-scoped configuration
  • Added real-time validation and error message feedback for node configuration settings, including tags and format specifications
  • Refactored component interfaces to reduce dependencies and improve maintainability
  • Standardized keyboard shortcut configuration across menu trigger features

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[linear]

ENG-1225 Discourse node: migrate settings

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[sid597]

• ENG-1225: Discourse node migration simple settings #696 : 2 dependent PRs (#697 , #764 ) 👈 (View in Graphite)
• ENG-1273: Migrate small personal settings #691
• ENG-1272 Migrate all small global settings components #688 : 1 other dependent PR (#690 )
• ENG-1345: Modify existing RoamJS component onChange to also change props #745 : 1 other dependent PR (#684 )
• ENG-1190 Replace existing roam-js components with blockProp based ones #689
• ENG-1188: prod: pull watchers for prop based settings #682
• ENG-1187: Prod: Implement get and set for block prop based settings #669
• ENG-1189: Prod: Init block prop based schema #666
• ENG-1330: zod schema for discourse relations #719
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Schema mismatch: accessing .value on a boolean. The schema was changed so isFirstChild is now a boolean (line 80 in zodSchema.ts), not an object with {uid, value}. This will always evaluate to false since undefined?.value is undefined.

// Fix:
initialValue={node.isFirstChild || false}

Suggested change

	initialValue={node.isFirstChild?.value || false}
	initialValue={node.isFirstChild || false}

Spotted by Graphite Agent



Is this helpful? React 👍 or 👎 to let us know.

[graphite-app]

Missing reactive update: removed useEffect that updated embeddingRef when node.embeddingRef changed. The DiscourseNodeTextPanel uses initialValue which only sets state on mount. If the parent component renders with a different node prop, the embedding ref input will show stale data.

// Add back:
useEffect(() => {
  setEmbeddingRef(node.embeddingRef || "");
}, [node.embeddingRef]);

Suggested change

	const [embeddingRef, setEmbeddingRef] = useState(node.embeddingRef || "");
	useEffect(() => {
	setEmbeddingRef(node.embeddingRef || "");
	}, [node.embeddingRef]);
	const blockUidToRender = useMemo(
	() => extractRef(embeddingRef),
	[embeddingRef, nodeUid]

Spotted by Graphite Agent



Is this helpful? React 👍 or 👎 to let us know.

[devin-ai-integration]

Devin Review found 1 new potential issue.

View 25 additional findings in Devin Review.

[devin-ai-integration]

🟡 Pending debounce not cleared on validation failure causes stale value to be persisted

When a user types a value that fails validation in BaseTextPanel, the function returns early without clearing the previously scheduled debounce timeout. This causes the prior (now-stale) valid value to be persisted to both block props and the Roam block tree.

Detailed scenario and root cause

Consider the "Tag" field in NodeConfig.tsx with format [[CLM]] - {content}:

1. User types "C" → valid → debounce scheduled to save "C" after 250ms (timeout A)
2. At t=100ms user types "CL" → valid → timeout A cleared, new debounce for "CL" (timeout B, fires at t=350ms)
3. At t=200ms user types "CLM" → invalid (conflicts with format) → getValidationError returns error → early return at BlockPropSettingPanels.tsx:136, timeout B is NOT cleared
4. At t=350ms, timeout B fires → saves "CL" via setter(settingKeys, "CL") and syncToBlock?.("CL")

The UI shows "CLM" with a red error message, but the partial value "CL" was silently persisted. The user never intended to save "CL" — they were still typing and got an error. This unintended intermediate save can also trigger downstream side effects.

Impact: Any DiscourseNodeTextPanel with a getValidationError prop (currently the Tag field) may persist unintended partial values.

Suggested change

	if (getValidationError?.(newValue)) return;
	window.clearTimeout(debounceRef.current);
	if (getValidationError?.(newValue)) return;

---

Was this helpful? React with 👍 or 👎 to provide feedback.