ENG-1328: Port small blueprint based misc settings into props based

[sid597]

https://www.loom.com/share/612bb20332b1445c977547b14b08b42a

Ported the following:

Queries -> Default filters

Grammar -> Nodes

Nodes -> type -> Format

Nodes -> type -> Attributes

Nodes -> type -> Attributes -> Overlay

Nodes -> type -> Canvas -> Color picker

Nodes -> type -> Canvas -> Display alias

Nodes -> type -> Canvas -> Key image location

Nodes -> type -> Canvas -> Query builder alias

Admin -> (BETA) Suggestive mode enabled

Admin -> Reified relation triples

---

Summary by CodeRabbit

• New Features

  • Enhanced feature flag management for Suggestive Mode and Reified relations.

• Bug Fixes

  • Improved settings persistence and synchronization across discourse node configurations, default filters, and attribute management.
  • Fixed color and alias handling in node canvas settings.

• Improvements

  • Strengthened node type creation and deletion workflows with better data validation and persistence.

[linear]

ENG-1328 Port small blueprint based misc settings into props based

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[sid597]

• ENG-1473: Port non-boolean personal setting consumers #818
• ENG-1456: Migrate personal boolean flag consumers (getSetting → getPersonalSetting) #814
• ENG-1472: Refactor BlockPropSettingPanels to add accessor-backed default reads (with initialValue fallback) #813
• ENG-1455: Dual-read from old-system settings and from blockprops #812
• ENG-1465: Enable dual read feature flag #811
• ENG-1217: Port section component in left sidebar #804
• ENG-1328: Port small blueprint based misc settings into props based #805 👈 (View in Graphite)
• graphite-base/805

This stack of pull requests is managed by Graphite. Learn more about stacking.

[sid597]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR adds centralized settings persistence across discourse node configuration and admin panels by introducing calls to setFeatureFlag, setPersonalSetting, and setDiscourseNodeSetting throughout settings components. It refactors component signatures to accept nodeType and onSync callbacks, replaces some inline UI with reusable panel components, and introduces strong typing for discourse relations.

Changes

Cohort / File(s)	Summary
Feature Flag & Personal Settings apps/roam/src/components/settings/AdminPanel.tsx, apps/roam/src/components/settings/DefaultFilters.tsx	AdminPanel now calls setFeatureFlag when toggling Suggestive Mode and Reified relations features. DefaultFilters refactored to use setPersonalSetting alongside extensionAPI.settings.set for dual persistence of default filters.
Discourse Node Settings Sync apps/roam/src/components/settings/DiscourseNodeAttributes.tsx, apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx, apps/roam/src/components/settings/DiscourseNodeConfigPanel.tsx, apps/roam/src/components/settings/NodeConfig.tsx	Multiple components now integrate setDiscourseNodeSetting to persist attribute edits, color changes, alias updates, and canvas settings. DiscourseNodeConfigPanel introduces strong typing for DiscourseRelation, calculates shortcut/format from labels, and handles deletion of affected relations. DiscourseNodeAttributes signature expanded to include nodeType parameter. NodeConfig refactors useDebouncedRoamUpdater signature, integrates DiscourseNodeSelectPanel, and adds onSync callback wiring.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• ENG-1187: Prod: Implement get and set for block prop based settings #669: Implements the setFeatureFlag, setPersonalSetting, and setDiscourseNodeSetting utilities that this PR depends on and uses throughout the settings components.
• Roam: When a user deletes a node also delete all the corresponding relations to the node - ENG-26 #149: Directly modifies DiscourseNodeConfigPanel to identify and delete affected relations when a discourse node type is removed, sharing core logic changes.
• ENG-1112: add suggestive mode flag and settings to admin panel #589: Directly modifies AdminPanel.tsx to manage the Suggestive Mode feature flag state and UI toggles.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main objective of the changeset: porting blueprint-based miscellaneous settings into a props-based implementation across multiple settings files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sid597]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 6 additional findings.