ENG-1465: Enable dual read feature flag

[sid597]

ENG-1454: Enable dual read feature flag

add caller

---

Summary by CodeRabbit

• New Features

  • Added "Enable dual read" toggle in Admin Panel settings to control alternative data read behavior.

• Chores

  • Improved settings lifecycle management for monitoring configuration changes.

[linear]

ENG-1465 Add "Enable dual read" feature flag with reactive accessor routing

ENG-1454 Base `getter()` task

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[sid597]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• ENG-1473: Port non-boolean personal setting consumers #818
• ENG-1456: Migrate personal boolean flag consumers (getSetting → getPersonalSetting) #814
• ENG-1472: Refactor BlockPropSettingPanels to add accessor-backed default reads (with initialValue fallback) #813
• ENG-1455: Dual-read from old-system settings and from blockprops #812
• ENG-1465: Enable dual read feature flag #811 👈 (View in Graphite)
• ENG-1217: Port section component in left sidebar #804
• ENG-1328: Port small blueprint based misc settings into props based #805
• graphite-base/805

This stack of pull requests is managed by Graphite. Learn more about stacking.

[sid597]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

📝 Walkthrough

Walkthrough

This PR introduces the "Enable dual read" feature flag with supporting infrastructure across multiple modules. The changes add UI rendering in AdminPanel, define the schema field, create an accessor utility, wire a feature flag handler with logging, and update the initialization flow to set up and tear down pull-watchers on application load/unload.

Changes

Cohort / File(s)	Summary
Feature Flag UI apps/roam/src/components/settings/AdminPanel.tsx	Added FeatureFlagPanel component import and rendering in FeatureFlagsTab with title, description, and featureKey for "Enable dual read".
Settings Schema & Utilities apps/roam/src/components/settings/utils/zodSchema.ts, apps/roam/src/components/settings/utils/accessors.ts	Added "Enable dual read" boolean field to FeatureFlagsSchema and created isDualReadEnabled() accessor utility for querying the feature flag.
Pull-Watchers Handler apps/roam/src/components/settings/utils/pullWatchers.ts	Added featureFlagHandlers entry for "Enable dual read" that logs transitions on flag changes; removed placeholder handlers.
Initialization Lifecycle apps/roam/src/index.ts	Updated initSchema to expose blockUids in return value and integrated setupPullWatchOnSettingsPage(blockUids) with corresponding cleanup on unload for settings page watcher lifecycle management.

Sequence Diagram

sequenceDiagram
    participant App as Application<br/>(index.ts)
    participant Schema as Settings Schema<br/>(initSchema)
    participant Watchers as Pull-Watchers<br/>(setupPullWatchOnSettingsPage)
    participant Handlers as Flag Handlers<br/>(featureFlagHandlers)
    participant UI as AdminPanel<br/>(FeatureFlagPanel)

    App->>Schema: initSchema()
    Schema-->>App: return { blockUids, ... }
    
    App->>Watchers: setupPullWatchOnSettingsPage(blockUids)
    Watchers->>Watchers: register handlers for feature flags
    Watchers-->>App: return cleanup function
    
    Note over UI: User toggles "Enable dual read"
    
    UI->>Handlers: Feature flag value changes
    Handlers->>Handlers: Execute "Enable dual read" handler
    Handlers->>Handlers: Console log transition (newValue, oldValue)
    
    Note over App: Application unload
    App->>App: cleanupPullWatchers()
    App->>Watchers: Execute cleanup function
    Watchers->>Watchers: Unregister watchers

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• ENG-1190 Replace existing roam-js components with blockProp based ones #689: Main PR directly imports and renders the FeatureFlagPanel component introduced in PR #689 for the "Enable dual read" flag UI.
• ENG-1188: prod: pull watchers for prop based settings #682: Main PR extends the pull-watch infrastructure from PR #682 by adding a specific feature flag handler entry and wiring setupPullWatchOnSettingsPage in the initialization flow.
• ENG-1189: Prod: Init block prop based schema #666: Main PR uses the updated initSchema return value (blockUids) which was introduced/expanded in PR #666 for settings initialization.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding an 'Enable dual read' feature flag to the system.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[devin-ai-integration]

Devin Review found 1 new potential issue.

View 5 additional findings in Devin Review.

[devin-ai-integration]

🟡 FeatureFlagPanel missing initialValue causes checkbox to always render unchecked

The new FeatureFlagPanel for "Enable dual read" in AdminPanel does not pass initialValue, so the checkbox always starts as unchecked regardless of the persisted feature flag state.

Root Cause

The BaseFlagPanel component initializes its internal state with initialValue ?? false (BlockPropSettingPanels.tsx:177-178). Since initialValue is not provided by the caller at AdminPanel.tsx:471-475, the checkbox always renders as unchecked.

The existing FeatureFlagPanel usage in GeneralSettings.tsx:43-47 correctly passes initialValue={settings.leftSidebarEnabled.value} to reflect the persisted state. The new usage should similarly read the stored value, e.g. via getFeatureFlag("Enable dual read") from accessors.ts:283-286.

Impact: If a user enables "Enable dual read", navigates away from the Admin Panel, and returns, the toggle will incorrectly show as unchecked even though the feature is still enabled. Toggling it again would be a no-op or cause confusion about the actual state.

Prompt for agents

In apps/roam/src/components/settings/AdminPanel.tsx, at lines 471-475, the FeatureFlagPanel for "Enable dual read" needs an initialValue prop to reflect the persisted state. Import getFeatureFlag from ~/components/settings/utils/accessors (it's already available in the file's scope since setFeatureFlag is imported from the same module). Then pass initialValue={getFeatureFlag("Enable dual read")} to the FeatureFlagPanel. Note that this should be computed inside the component, ideally via useMemo or during the initial render, similar to how GeneralSettings.tsx:46 passes initialValue={settings.leftSidebarEnabled.value}. You may need to add getFeatureFlag to the existing import statement on line 41.

---

Was this helpful? React with 👍 or 👎 to provide feedback.