ENG-1440: Port page groups settings in suggestive mode

[sid597]

https://www.loom.com/share/dcdbb3b9441145fe94bf152f84fff80b

---

Summary by CodeRabbit

• Bug Fixes

  • Page group persistence improved. Groups now properly synchronize with global settings whenever changes occur—when groups are created, deleted, or when pages are added to or removed from groups. Changes are immediately saved.

• New Features

  • Schema initialization now runs automatically on extension startup, ensuring the extension is properly configured without requiring manual intervention.

[linear]

ENG-1440 Port page groups settings in suggestive mode

ENG-1217 Section components in Left sidebar

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[sid597]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

Caution

Review failed

An error occurred during the review process. Please try again later.

📝 Walkthrough

Walkthrough

This change introduces schema initialization during extension load and synchronizes PageGroup state changes with global settings storage through a new syncPageGroupsToBlockProps helper function that persists local group modifications.

Changes

Cohort / File(s)	Summary
Settings State Synchronization apps/roam/src/components/settings/PageGroupPanel.tsx	Adds syncPageGroupsToBlockProps() helper to persist PageGroup changes to global settings and updates all group modification handlers (create, remove, add page, remove page) to call this sync function after state updates.
Extension Initialization apps/roam/src/index.ts	Imports and invokes initSchema() during extension initialization, placing the call before returning the public interface to ensure schema setup runs on load.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• ENG-1190 Replace existing roam-js components with blockProp based ones #689 — Introduces block-prop-based getters and setters for Roam settings, providing the underlying mechanism that this PR leverages for setGlobalSetting.
• ENG-1345: Modify existing RoamJS component onChange to also change props #745 — Extends settings UI panels with block-sync behavior and properties, complementing the state synchronization pattern implemented here.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The PR title references 'ENG-1440' but the PR objectives mention 'ENG-1217', creating a mismatch. Additionally, the title 'Port page groups settings in suggestive mode' is overly broad and vague—the actual changes focus on synchronizing page group settings to block properties (dual-write implementation), which is more specific than the generic 'port' language suggests.	Clarify the ticket reference (ENG-1440 vs ENG-1217) and consider a more specific title that captures the dual-write synchronization of page groups to block properties, such as 'Sync page groups to block properties'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

[sid597]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• ENG-1438: Port Keyboard shortcut keys/triggers settings #794
• ENG-1440: Port page groups settings in suggestive mode #793 👈 (View in Graphite)
• ENG-1281: Port discourse node block panel #784 : 2 other dependent PRs (#795 , #805 )
• ENG-1290: Port discourse node config panel #769
• ENG-1291: Port discourse node specification #765
• ENG-1280: Port Discourse node: Query builder and editor component for block props #764
• ENG-1225: Discourse node migration simple settings #696 : 1 other dependent PR (#697 )
• ENG-1273: Migrate small personal settings #691
• ENG-1272 Migrate all small global settings components #688 : 1 other dependent PR (#690 )
• ENG-1345: Modify existing RoamJS component onChange to also change props #745 : 1 other dependent PR (#684 )
• ENG-1190 Replace existing roam-js components with blockProp based ones #689
• ENG-1188: prod: pull watchers for prop based settings #682
• ENG-1187: Prod: Implement get and set for block prop based settings #669
• ENG-1189: Prod: Init block prop based schema #666
• ENG-1330: zod schema for discourse relations #719
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[mdroidian]

👍

Couple of Devin comments worth looking into, but not blocking.