ignore ime insets in navigation view#6845
Merged
Zayankovsky merged 2 commits intomainfrom Jan 24, 2023
Merged
Conversation
ChangelogFeatures
Bug fixes and improvements
Known issues
|
39a53ca to
bd5c950
Compare
Codecov Report
@@ Coverage Diff @@
## main #6845 +/- ##
============================================
- Coverage 72.65% 72.63% -0.03%
+ Complexity 5565 5561 -4
============================================
Files 781 781
Lines 30128 30113 -15
Branches 3562 3555 -7
============================================
- Hits 21890 21873 -17
- Misses 6815 6817 +2
Partials 1423 1423
|
Contributor
|
Running this branch I am seeing issue with the puck which hides beneath road name view in portrait mode and it is cut in the landscape mode Record_2023-01-19-12-23-17.mp4 |
bd5c950 to
6bb4ed5
Compare
Contributor
Author
This should be fixed now, thanks. |
6bb4ed5 to
9274508
Compare
abhishek1508
approved these changes
Jan 23, 2023
This was referenced Jan 24, 2023
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed extra
CoordinatorLayoutwithfitsSystemWindowsand set paddings according to the current insets manually. The issue withfitsSystemWindowsis that it also reacts to keyboard insets, whileNavigationViewContext.systemBarsInsetsonly contains system bar insets. This leads to inconsistencies, e.g. when keyboard is shown the road name view will end up at the top of the screen despite the 50% guideline top position limitation we have.Before:
before.mp4
After:
after.mp4