Auto-vectorize mixed-path offsets construction#7998
Closed
joseph-isaacs wants to merge 1 commit into
Closed
Conversation
Apply the same `Vec::push` → raw-pointer-write transformation to the mixed (fixed-plus-varlen) branch of Phase 3. We already validated the total fits in u32 upstream, so `wrapping_mul` / `wrapping_add` here are sound. Mixed paths within the bench noise; this commit keeps the pure-fixed and mixed branches structurally identical so reviewers see the same shape regardless of whether varlen is present. Signed-off-by: Claude <noreply@anthropic.com>
This was referenced May 18, 2026
This was referenced May 18, 2026
Closed
Merging this PR will improve performance by 10.52%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | iter_arrow_buffer[128] |
919.4 ns | 831.9 ns | +10.52% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/row-c13-vectorize-mixed-offsets (f76ed6f) with develop (52e26d1)1
Footnotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 13 of 25 in the stacked PR series adding
vortex-row.This PR contains exactly one commit; review just that diff in isolation.
What this commit does
Applies the same
Vec::push→ raw-pointer-write transformation to the mixed (fixed-plus-varlen) branch of Phase 3. We already validated the total fits in u32 upstream, sowrapping_mul/wrapping_addhere are sound.Mixed paths within the bench noise; this commit keeps the pure-fixed and mixed branches structurally identical so reviewers see the same shape regardless of whether varlen is present.
Stack
claude/row-c01-crate-scaffoldingclaude/row-c02-sortfield-optionsclaude/row-c03-codec-fixed-widthclaude/row-c04-codec-varlenclaude/row-c05-codec-nestedclaude/row-c06-rowsize-scalarfnclaude/row-c07-rowencode-scalarfnclaude/row-c08-convert-columns-tests-benchclaude/row-c09-skip-listview-validationclaude/row-c10-validity-fast-pathclaude/row-c11-skip-zero-initclaude/row-c12-vectorize-pure-fixed-offsetsclaude/row-c13-vectorize-mixed-offsetsclaude/row-c14-varlen-block-copy-nonoverlappingclaude/row-c15-walk-varbinview-directlyclaude/row-c16-arith-write-fast-pathclaude/row-c17-specialize-constant-arithclaude/row-c18-kernel-dispatch-helpersclaude/row-c19-inventory-registryclaude/row-c20-constant-kernelclaude/row-c21-dict-kernelclaude/row-c22-patched-kernelclaude/row-c23-runend-kernelclaude/row-c24-bitpacked-kernelclaude/row-pr3-kernelsBase of this PR: #7997 (
claude/row-c12-vectorize-pure-fixed-offsets)Next in stack: #7999 (
claude/row-c14-varlen-block-copy-nonoverlapping)Combined context
For the full design + rationale, see PR #7985 (top of stack).