Patched row-encode kernel#8007
Closed
joseph-isaacs wants to merge 1 commit into
Closed
Conversation
Replace the stub `RowSizeKernel` / `RowEncodeKernel` impls for `Patched` with real implementations. Size pass: per-row size matches the inner array exactly because patches share the inner dtype. Just delegate to `dispatch_size` on the inner array. Encode pass: delegate to `dispatch_encode` on the inner array, then walk the patch indices and overwrite each patched row's value bytes in place. Patched arrays in our hot paths are Primitive-typed (BitPacked with patches, etc.), so the kernel checks `DType::Primitive` upfront and declines for anything else. Pre-cursor snapshot is captured before the inner encoder advances `cursors`, so the overlay knows each row's slot start position. Adds `patched_i32_*` bench triplet. Patched-specific tests live next to the kernel in `kernels/patched.rs::tests` (round-trip vs canonical, both single-chunk and multi-chunk). Signed-off-by: Claude <noreply@anthropic.com>
This was referenced May 18, 2026
This was referenced May 18, 2026
Closed
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
358.4 µs | 325 µs | +10.26% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
273.3 µs | 309 µs | -11.56% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
197.9 µs | 161.9 µs | +22.25% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/row-c22-patched-kernel (b86974e) with develop (faf7e42)1
Footnotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 22 of 25 in the stacked PR series adding
vortex-row.This PR contains exactly one commit; review just that diff in isolation.
What this commit does
Replaces the stub
RowSizeKernel/RowEncodeKernelimpls forPatchedwith real implementations.Size pass: per-row size matches the inner array exactly because patches share the inner dtype. Just delegates to
dispatch_sizeon the inner array.Encode pass: delegates to
dispatch_encodeon the inner array, then walks the patch indices and overwrites each patched row's value bytes in place. Patched arrays in our hot paths are Primitive-typed (BitPacked with patches, etc.), so the kernel checksDType::Primitiveupfront and declines for anything else.Pre-cursor snapshot is captured before the inner encoder advances
cursors, so the overlay knows each row's slot start position.Adds
patched_i32_*bench triplet. Patched-specific tests live next to the kernel inkernels/patched.rs::tests.Stack
claude/row-c01-crate-scaffoldingclaude/row-c02-sortfield-optionsclaude/row-c03-codec-fixed-widthclaude/row-c04-codec-varlenclaude/row-c05-codec-nestedclaude/row-c06-rowsize-scalarfnclaude/row-c07-rowencode-scalarfnclaude/row-c08-convert-columns-tests-benchclaude/row-c09-skip-listview-validationclaude/row-c10-validity-fast-pathclaude/row-c11-skip-zero-initclaude/row-c12-vectorize-pure-fixed-offsetsclaude/row-c13-vectorize-mixed-offsetsclaude/row-c14-varlen-block-copy-nonoverlappingclaude/row-c15-walk-varbinview-directlyclaude/row-c16-arith-write-fast-pathclaude/row-c17-specialize-constant-arithclaude/row-c18-kernel-dispatch-helpersclaude/row-c19-inventory-registryclaude/row-c20-constant-kernelclaude/row-c21-dict-kernelclaude/row-c22-patched-kernelclaude/row-c23-runend-kernelclaude/row-c24-bitpacked-kernelclaude/row-pr3-kernelsBase of this PR: #8006 (
claude/row-c21-dict-kernel)Next in stack: #8008 (
claude/row-c23-runend-kernel)Combined context
For the full design + rationale, see PR #7985 (top of stack).