Add arithmetic-write fast path for fixed-before-varlen columns#8001
Closed
joseph-isaacs wants to merge 1 commit into
Closed
Add arithmetic-write fast path for fixed-before-varlen columns#8001joseph-isaacs wants to merge 1 commit into
joseph-isaacs wants to merge 1 commit into
Conversation
ColKind::Fixed { before_varlen: true, .. } columns have a constant
within-row write offset (sum of preceding fixed-column widths plus
i * fixed_per_row plus var_prefix[i] when varlen columns are present).
For these we don't need a per-row cursor; the position is pure
arithmetic.
Adds dispatch_encode_fixed_arith + field_encode_fixed_arithmetic and
routes the relevant ColKind arm of execute_row_encode's phase 4
through them. Fixed-after-varlen columns and varlen columns continue
through the existing cursor path.
primitive_i64 vortex 3.0 -> 6+ GB/s.
Signed-off-by: Claude <noreply@anthropic.com>
This was referenced May 18, 2026
This was referenced May 18, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 16 of 25 in the stacked PR series adding
vortex-row.This PR contains exactly one commit; review just that diff in isolation.
What this commit does
ColKind::Fixed { before_varlen: true, .. }columns have a constant within-row write offset (sum of preceding fixed-column widths plusi * fixed_per_rowplusvar_prefix[i]when varlen columns are present). For these we don't need a per-row cursor; the position is pure arithmetic.Adds
dispatch_encode_fixed_arith+field_encode_fixed_arithmeticand routes the relevant ColKind arm of execute_row_encode's phase 4 through them. Fixed-after-varlen columns and varlen columns continue through the existing cursor path.primitive_i64 vortex 3.0 → 6+ GB/s.
Stack
claude/row-c01-crate-scaffoldingclaude/row-c02-sortfield-optionsclaude/row-c03-codec-fixed-widthclaude/row-c04-codec-varlenclaude/row-c05-codec-nestedclaude/row-c06-rowsize-scalarfnclaude/row-c07-rowencode-scalarfnclaude/row-c08-convert-columns-tests-benchclaude/row-c09-skip-listview-validationclaude/row-c10-validity-fast-pathclaude/row-c11-skip-zero-initclaude/row-c12-vectorize-pure-fixed-offsetsclaude/row-c13-vectorize-mixed-offsetsclaude/row-c14-varlen-block-copy-nonoverlappingclaude/row-c15-walk-varbinview-directlyclaude/row-c16-arith-write-fast-pathclaude/row-c17-specialize-constant-arithclaude/row-c18-kernel-dispatch-helpersclaude/row-c19-inventory-registryclaude/row-c20-constant-kernelclaude/row-c21-dict-kernelclaude/row-c22-patched-kernelclaude/row-c23-runend-kernelclaude/row-c24-bitpacked-kernelclaude/row-pr3-kernelsBase of this PR: #8000 (
claude/row-c15-walk-varbinview-directly)Next in stack: #8002 (
claude/row-c17-specialize-constant-arith)Combined context
For the full design + rationale, see PR #7985 (top of stack).