Walk VarBinView rows directly in row encoder hot loop#8000
Closed
joseph-isaacs wants to merge 1 commit into
Closed
Walk VarBinView rows directly in row encoder hot loop#8000joseph-isaacs wants to merge 1 commit into
joseph-isaacs wants to merge 1 commit into
Conversation
`arr.with_iterator(...)` constructs an `Option<&[u8]>` per row through a trait-object dispatch and a branch-and-merge that hides the inline-vs-buffer view from the compiler. On the AllValid path we don't need the Option (no nulls) and we want the compiler to see the inline-vs-buffer branch directly so it can keep the inline arm in registers. Walk `arr.views()` directly and resolve each view via `is_inlined() → as_inlined().value()` vs `as_view() → buffers[idx][offset..len]`. Cache data-buffer slices once before the loop (SmallVec for ≤4 buffers, the common case). Nullable path is unchanged because the Option<&[u8]> shape is already what we want when nulls are possible. utf8 throughput: ~1.49 GB/s → ~1.84 GB/s. Signed-off-by: Claude <noreply@anthropic.com>
This was referenced May 18, 2026
This was referenced May 18, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 15 of 25 in the stacked PR series adding
vortex-row.This PR contains exactly one commit; review just that diff in isolation.
What this commit does
arr.with_iterator(...)constructs anOption<&[u8]>per row through a trait-object dispatch and a branch-and-merge that hides the inline-vs-buffer view from the compiler. On the AllValid path we don't need the Option (no nulls) and we want the compiler to see the inline-vs-buffer branch directly so it can keep the inline arm in registers.Walks
arr.views()directly and resolves each view viais_inlined() → as_inlined().value()vsas_view() → buffers[idx][offset..len]. Caches data-buffer slices once before the loop (SmallVec for ≤4 buffers, the common case). Nullable path is unchanged because the Option<&[u8]> shape is already what we want when nulls are possible.utf8 throughput: ~1.49 GB/s → ~1.84 GB/s.
Stack
claude/row-c01-crate-scaffoldingclaude/row-c02-sortfield-optionsclaude/row-c03-codec-fixed-widthclaude/row-c04-codec-varlenclaude/row-c05-codec-nestedclaude/row-c06-rowsize-scalarfnclaude/row-c07-rowencode-scalarfnclaude/row-c08-convert-columns-tests-benchclaude/row-c09-skip-listview-validationclaude/row-c10-validity-fast-pathclaude/row-c11-skip-zero-initclaude/row-c12-vectorize-pure-fixed-offsetsclaude/row-c13-vectorize-mixed-offsetsclaude/row-c14-varlen-block-copy-nonoverlappingclaude/row-c15-walk-varbinview-directlyclaude/row-c16-arith-write-fast-pathclaude/row-c17-specialize-constant-arithclaude/row-c18-kernel-dispatch-helpersclaude/row-c19-inventory-registryclaude/row-c20-constant-kernelclaude/row-c21-dict-kernelclaude/row-c22-patched-kernelclaude/row-c23-runend-kernelclaude/row-c24-bitpacked-kernelclaude/row-pr3-kernelsBase of this PR: #7999 (
claude/row-c14-varlen-block-copy-nonoverlapping)Next in stack: #8001 (
claude/row-c16-arith-write-fast-path)Combined context
For the full design + rationale, see PR #7985 (top of stack).