Inventory-based registry for downstream encoding kernels#8004
Closed
joseph-isaacs wants to merge 1 commit into
Closed
Inventory-based registry for downstream encoding kernels#8004joseph-isaacs wants to merge 1 commit into
joseph-isaacs wants to merge 1 commit into
Conversation
Encodings that live outside `vortex-array` (e.g. RunEnd, BitPacked, FoR, Delta) can't be downcast from inside the variadic dispatch loops - vortex-array doesn't know about them, and reversing the dependency would create a cycle. Add a `RowEncodeRegistration` that downstream crates submit via the inventory crate. `lookup(&array_id)` lazily builds an `ArrayId → (size, encode)` HashMap on first call, behind a `OnceLock` so the build is single-threaded and the lookups are wait-free thereafter. Wire the lookup into `dispatch_size` / `dispatch_encode` after the in-crate downcast attempts: in-crate kernels take precedence (constant- time downcast), then downstream registrations (HashMap lookup), then the canonicalization fallback. Signed-off-by: Claude <noreply@anthropic.com>
This was referenced May 18, 2026
This was referenced May 18, 2026
Closed
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
273.3 µs | 309 µs | -11.56% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
197.9 µs | 161.9 µs | +22.25% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
358.4 µs | 325 µs | +10.26% |
| ❌ | Simulation | new_alp_prim_test_between[f32, 16384] |
103.9 µs | 118.3 µs | -12.18% |
| ❌ | Simulation | new_alp_prim_test_between[f32, 32768] |
153.3 µs | 182.1 µs | -15.82% |
| ⚡ | Simulation | iter_arrow_buffer[128] |
919.4 ns | 831.9 ns | +10.52% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/row-c19-inventory-registry (c0b24ad) with develop (faf7e42)1
Footnotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 19 of 25 in the stacked PR series adding
vortex-row.This PR contains exactly one commit; review just that diff in isolation.
What this commit does
Encodings that live outside
vortex-array(e.g. RunEnd, BitPacked, FoR, Delta) can't be downcast from inside the variadic dispatch loops — vortex-array doesn't know about them, and reversing the dependency would create a cycle.Adds a
RowEncodeRegistrationthat downstream crates submit via the inventory crate.lookup(&array_id)lazily builds anArrayId → (size, encode)HashMap on first call, behind aOnceLockso the build is single-threaded and the lookups are wait-free thereafter.Wires the lookup into
dispatch_size/dispatch_encodeafter the in-crate downcast attempts: in-crate kernels take precedence (constant-time downcast), then downstream registrations (HashMap lookup), then the canonicalization fallback.Stack
claude/row-c01-crate-scaffoldingclaude/row-c02-sortfield-optionsclaude/row-c03-codec-fixed-widthclaude/row-c04-codec-varlenclaude/row-c05-codec-nestedclaude/row-c06-rowsize-scalarfnclaude/row-c07-rowencode-scalarfnclaude/row-c08-convert-columns-tests-benchclaude/row-c09-skip-listview-validationclaude/row-c10-validity-fast-pathclaude/row-c11-skip-zero-initclaude/row-c12-vectorize-pure-fixed-offsetsclaude/row-c13-vectorize-mixed-offsetsclaude/row-c14-varlen-block-copy-nonoverlappingclaude/row-c15-walk-varbinview-directlyclaude/row-c16-arith-write-fast-pathclaude/row-c17-specialize-constant-arithclaude/row-c18-kernel-dispatch-helpersclaude/row-c19-inventory-registryclaude/row-c20-constant-kernelclaude/row-c21-dict-kernelclaude/row-c22-patched-kernelclaude/row-c23-runend-kernelclaude/row-c24-bitpacked-kernelclaude/row-pr3-kernelsBase of this PR: #8003 (
claude/row-c18-kernel-dispatch-helpers)Next in stack: #8005 (
claude/row-c20-constant-kernel)Combined context
For the full design + rationale, see PR #7985 (top of stack).